Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: avoid square root computation when possible #19

Merged
merged 4 commits into from
May 17, 2024
Merged

perf: avoid square root computation when possible #19

merged 4 commits into from
May 17, 2024

Conversation

winstxnhdw
Copy link
Contributor

@winstxnhdw winstxnhdw commented May 15, 2024

Summary

This PR reduces the number of redundant square root operations. I have not measured but some of these operations are located within seemingly hot loops.

Signed-off-by: winstxnhdw <winstxnhdw@gmail.com>
@winstxnhdw
Copy link
Contributor Author

winstxnhdw commented May 15, 2024

Off-topic:

I'd like to start contributing to mapf and rmf-site but before that, I have some questions on the design decisions. Is there a platform where I can reach out to the maintainers about this? Just so that I can more meaningfully contribute?

@arjo129
Copy link
Member

arjo129 commented May 16, 2024

@mxgrey is the right person to talk to. A lot if the rust code is experimental, so there is a high chance that rework may be needed.

@mxgrey
Copy link
Contributor

mxgrey commented May 16, 2024

the rust code is experimental

I think conceptually I'm pretty happy with how the library has turned out, so I don't expect many breaking changes at this point, except maybe to eliminate dependencies on Nightly release features which never seem to be making it to Stable.

The main issue right now (at least in my mind) is that defining a custom domain requires an enormous amount of boilerplate, but I think the best way to solve that is to provide procedural macros so that users can just define a struct and tag it with attributes to describe how the domain should behave.

But now I'm getting very off topic. Thanks for the PR!

Signed-off-by: winstxnhdw <winstxnhdw@gmail.com>
Signed-off-by: winstxnhdw <winstxnhdw@gmail.com>
@mxgrey mxgrey merged commit b97c367 into open-rmf:main May 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants